Enable coverage when viaIR compiler flag is true#854
Merged
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #854 +/- ##
==========================================
- Coverage 95.92% 95.77% -0.16%
==========================================
Files 19 19
Lines 981 1017 +36
==========================================
+ Hits 941 974 +33
- Misses 40 43 +3 ☔ View full report in Codecov by Sentry. |
Member
Author
|
E2E tested against 1inch solidity-utils and got the output below. NB: there was a failing test that looked at gas specific values - to be expected because the instrumentation mechanism changed and there's some consumption variance.
|
cgewecke
changed the title
viaIR compiler flag is trueviaIR compiler flag is true
This was referenced Jul 17, 2024
This was referenced Sep 19, 2024
This was referenced Sep 24, 2024
This was referenced Oct 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PUBLISHED at the viaIR tag
#853, #848, #790, #715, #417
Uses solidity built-in ignored by the yul optimizer to preserve instrumentation when
viaIRis set to true. This should address all the insane optimizer config problems.Coverage in the plugin's own tests is missing for an edge case where the optimizer has:
... we hit the first two conditions in the integration tests but the hash is a duplicate.
TODO
e2e test on Zeppelin with viaIR flag set to true and verify coverage is identicalviaIRto true in solc results in zero coverage #715 (comment))Add tests for file-level function declarations (weirdly missing)